This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
AR-2148 Fix repeated rendering of global styles for tooltip-like components #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinanastos
force-pushed
the
justin/AR-2148/limit-global-renders
branch
3 times, most recently
from
4493c22
to
57261e0
Compare
cheapsteak
approved these changes
Mar 10, 2021
This will ensure that regardless of how many times you render the component simultaneously, only a single element will exist in the DOM.
justinanastos
force-pushed
the
justin/AR-2148/limit-global-renders
branch
from
4327f8a
to
ffeda9f
Compare
|
🚀 PR was released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue AR-2148
We are rendering
<Global>styles for all instances ofAbstractTooltip, of which there can be thousands lying in wait on a single page. I incorrectly believed that these would be rendered just once to the DOM, but I was wrong; they are rendered once per instance rendered. This resulted in thousands of duplicated<style>tags being added.Release Notes
SingletonComponent(the name is poor and can be changed whenever we want because it's internal) that will take a stringidentityand only allow a single instance in the DOM regardless of how many times it's rendered. This requires us to useSpaceKitProvider. Tooltips can be used withoutSpaceKitProviderand will warn the user in the console.<Global>styles with theSingletonComponentto remove all excess DOM<style />s📦 Published PR as canary version:
8.17.4-canary.330.8834.0✨ Test out this PR locally via:
npm install @apollo/space-kit@8.17.4-canary.330.8834.0 # or yarn add @apollo/space-kit@8.17.4-canary.330.8834.0