This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
AP-703: Write integration tests (AP-780) #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinanastos
force-pushed
the
justin/tests
branch
2 times, most recently
from
d55ada1
to
cdf3afd
Compare
justinanastos
force-pushed
the
justin/tests
branch
from
cdf3afd
to
f491efd
Compare
justinanastos
requested review from
cheapsteak,
mayakoneval,
timbotnik and
trevorblades
mayakoneval
reviewed
Jul 30, 2019
mayakoneval
reviewed
Jul 30, 2019
mayakoneval
approved these changes
Jul 30, 2019
There was a problem hiding this comment.
I'm really excited about this. I can't think of any cases that we have missed right now, but it should be standard for people opening space-kit PR's to add tests for each new prop / new component.
As long as we are of the mind that these ci / jest tests cover components being rendered and chromatic covers the appearance of components, I have confidence that a passing PR can be merged without issues.
Merged
justinanastos
force-pushed
the
justin/tests
branch
from
f491efd
to
4b182f1
Compare
justinanastos
force-pushed
the
justin/tests
branch
3 times, most recently
from
0c76589
to
784abe0
Compare
justinanastos
changed the title
justinanastos
changed the title
justinanastos
force-pushed
the
justin/tests
branch
2 times, most recently
from
77b13f1
to
479be48
Compare
cheapsteak
approved these changes
Sep 3, 2019
justinanastos
force-pushed
the
justin/tests
branch
from
479be48
to
cca87cb
Compare
|
🚀 PR was released in v2.3.0 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second pass at writing integration tests. We don't target any code coverage, we only test things that give us increased confidence. If the tests pass, we should be confident to release. Not all components are tested yet, we can add more tests as we go.
I also included some resources to read about testing and some very very rough guidelines on what I'd be looking for. Please open PRs to help tell our story!
Resolves AP-703 and AP-780