Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

update peer dependencies versions #340

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Conversation

Jephuff
Copy link
Contributor

@Jephuff Jephuff commented Apr 16, 2021

updating react dependencies from >16 to >=16 to match the version we use in other projects. >16 will only match 17 and up.
image

πŸ“¦ Published PR as canary version: 8.20.1-canary.340.9080.0

✨ Test out this PR locally via:

npm install @apollo/space-kit@8.20.1-canary.340.9080.0
# or 
yarn add @apollo/space-kit@8.20.1-canary.340.9080.0

@Jephuff Jephuff requested a review from a team April 16, 2021 00:30
Copy link
Contributor

@jglovier jglovier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Jephuff Jephuff added the bug fix Increment the patch version when merged label Apr 16, 2021
@jglovier
Copy link
Contributor

Is it a Chromatic bug that is causing UI Tests to show a diff for this change, or do updating these packages actually create a diff in the rendering of these stories?

@justinanastos
Copy link
Contributor

@jglovier it's a bug in the popup library we use, tippy. We see stuff off by a pixel all the time :(

@Jephuff Jephuff merged commit e83eabc into main Apr 19, 2021
@Jephuff Jephuff deleted the jeffrey/update-peer-dep-versions branch April 19, 2021 13:08
@apollo-bot2
Copy link
Collaborator

πŸš€ PR was released in v8.20.1 πŸš€

@apollo-bot2 apollo-bot2 added the released This issue/pull request has been released. label Apr 19, 2021
glasser pushed a commit that referenced this pull request Jun 1, 2021
This is needed for gatsby-theme-apollo-core which isn't ready to take the major
version bumps.
glasser added a commit that referenced this pull request Jun 1, 2021
This is needed for gatsby-theme-apollo-core which isn't ready to take the major
version bumps.

Co-authored-by: Jeffrey Burt <hi@jeffreyburt.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants