This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Use onMouseDown instead of onClick for auto closing modals #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jephuff
force-pushed
the
jeffrey/use-mouse-down-instead-of-on-click
branch
from
7cd4921
to
66f408d
Compare
…g mouse outside will not close it
Jephuff
force-pushed
the
jeffrey/use-mouse-down-instead-of-on-click
branch
from
66f408d
to
d007890
Compare
cheapsteak
approved these changes
Apr 22, 2021
cheapsteak
reviewed
Apr 22, 2021
src/Modal/Modal.tsx
Outdated
| @@ -140,6 +140,11 @@ export const Modal: React.FC<Props> = ({ | |||
| primaryAction, | |||
| secondaryAction, | |||
| }) => { | |||
| const mouseDownTarget = useRef<EventTarget | null>(null); | |||
There was a problem hiding this comment.
would we ever want this to store a reference to something other than the backdrop element?
There was a problem hiding this comment.
nope, are you thinking renaming to something like backdropMouseDownTarget?
There was a problem hiding this comment.
yes please 👍
I was briefly confused trying to figure out why weren't clearing out the reference in the onClick so the stale one isn't used again
There was a problem hiding this comment.
(feel free to merge at will following rename btw)
cheapsteak
approved these changes
Apr 22, 2021
|
🚀 PR was released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will prevent clicking in the modal and moving mouse outside from closing the modal
📦 Published PR as canary version:
8.20.2-canary.342.9199.0✨ Test out this PR locally via:
npm install @apollo/space-kit@8.20.2-canary.342.9199.0 # or yarn add @apollo/space-kit@8.20.2-canary.342.9199.0