Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

Export colors as a constant #35

Merged
merged 2 commits into from
Aug 2, 2019
Merged

Conversation

justinanastos
Copy link
Contributor

This will require we change how we import colors.

Old:

import * as colors from '@apollo/space-kit/colors';

New:

import { colors } from '@apollo/space-kit/colors';

The import * is awkward and it's a pain to remember when we need that. So let's never do it.

@justinanastos justinanastos changed the base branch from master to justin/move-files July 30, 2019 16:44
@justinanastos justinanastos changed the base branch from justin/move-files to master July 30, 2019 16:49
@justinanastos justinanastos force-pushed the justin/export-colors-const branch 2 times, most recently from bdc18d5 to a1f9af0 Compare July 30, 2019 16:59
Copy link
Contributor

@mayakoneval mayakoneval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet lgtm. please ping me when published so I can update my engine prs!

@timbotnik
Copy link
Contributor

i think this negates any possibility of tree-shaking based on only importing a subset of colors, but everyone always doing import * coupled with the fact that we are only talking about a few constant definitions indicates to me that this is not a very serious objection.

@justinanastos justinanastos merged commit 366873e into master Aug 2, 2019
@justinanastos justinanastos deleted the justin/export-colors-const branch August 2, 2019 19:24
@justinanastos justinanastos added the released This issue/pull request has been released. label Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants