Fix Popover component not being able to render >800 times without taking a dump on the main thread

[brainkim]

📦 Published PR as canary version: 9.1.1-canary.357.9555.0

✨ Test out this PR locally via:

npm install @apollo/space-kit@9.1.1-canary.357.9555.0
# or 
yarn add @apollo/space-kit@9.1.1-canary.357.9555.0

[cheapsteak]

Sweet, and thank you!
I'm surprised that just memoizing modifiers is enough, were the props like content and children red herring?

[cheapsteak]

Should we do similarly for AbstractTooltip?

[cheapsteak]

Ah just read the comment more carefully
Sounds like this only happens when the array of modifiers includes callbacks (which is just here)
Great find!

[brainkim]

@cheapsteak I was thinking about this in the shower. Before we merge, one alternative is to define the callbacks at the module scope, so we don’t have to use useMemo(). The thing is, the problem would still exist if the fallbackPlacements variable changed, though it would occur at a much slower pace.

[apollo-bot2]

🚀 PR was released in v9.2.0 🚀