This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
modal - should be no title OR description on top margin #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cy
added
patch
jgzuke
approved these changes
Aug 24, 2021
| marginTop: | ||
| size === "large" ? 24 : size === "medium" ? 16 : 12, | ||
| }, | ||
| (title || description) && { |
There was a problem hiding this comment.
Im not quite sure about having description here? Does the description render in the top section? I would assume this would just be title &&
There was a problem hiding this comment.
I think the logic is right but the title is possibly confused?
this makes sense (title || description) ? defaultMargin : noMargin which is what the code has
(gosh this component is getting tangly though, really want to chop it up)
There was a problem hiding this comment.
Does the description render in the top section
it looks like it does
There was a problem hiding this comment.
yeah, the description does render in the top section - very tangly component FOR SURE
|
🚀 PR was released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a mistake in #373, instead of not having a top margin between the content if there's no title and no description, it should be no title OR no description. The mistake's effect can see in this chromatic https://www.chromatic.com/test?appId=5a77a6d38a9e3c002045d20d&id=61255022235bb7003aae37f0
before
after
