This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Refactor icon generation #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using @babel/types allows us to keep the AST manipulation more concise and type-safe
mayakoneval
approved these changes
Aug 8, 2019
We now use `src/icons` as the temporary directory for our generated TypeScript icons. Even though I don't like this, it makes the most sense because now TypeScript can treat all our files we're goign to transpile for consumers the same way.
We can import real icon files now.
justinanastos
force-pushed
the
justin/move-icons
branch
from
511539c
to
1c694fa
Compare
|
🚀 PR was released in v1.0.5 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
Refactor icon conversion script to use
@babel/typesinstead ofimmutability-helperand trying to craft AST by hand. That was too opaque and it wasn't type safe. Now we're safe and it's as concise as it's going to get.Move intermediate icon files to
src/iconsThis makes them accessible from anywhere else and gives them access to other modules. We were going to use this for the
EmotionProvider, but now we aren't. This is less elegant and clever, but makes more sense and will make our code actually work.