This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Correct npm script for cleaning TextField, make labels optional #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/TextField/TextField.tsx
Outdated
| @@ -49,7 +49,7 @@ interface Props { | |||
| /** | |||
| * Visible title | |||
| */ | |||
| label: React.ReactNode; | |||
| label?: React.ReactNode; | |||
There was a problem hiding this comment.
Now that the label is optional we need to conditionally render it as well, otherwise we'll have padding and margins on an empty element.
I'm going to say this is good and defer that to #67 ? I'm going to 👍 both of these. If they both merge, then they'll work together 🤝
|
@mayakoneval Remember, whatever you put in the title of a PR is what's going to be added to the changelog |
justinanastos
added
skip-release
justinanastos
approved these changes
Aug 15, 2019
justinanastos
added
patch
and removed
skip-release
|
/rebase |
github-actions
bot
force-pushed
the
mkoneval/npm-script
branch
from
7beec02 to
655f8c2
Compare
mayakoneval
changed the title
|
🚀 PR was released in v1.5.1 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
@justinanastos made an update to the TextField logic and didn't update the clean script. This fixes it.