This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Button: add 12px padding and expanded content example #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayakoneval
approved these changes
Aug 22, 2019
justinanastos
suggested changes
Aug 23, 2019
src/Button/Button.tsx
Outdated
| @@ -425,6 +425,8 @@ export const Button: ComponentWithAs<Props, "button"> = ({ | |||
| alignItems: "center", | |||
| display: "flex", | |||
| justifyContent: "center", | |||
| paddingLeft: "12px", | |||
There was a problem hiding this comment.
These changes need to be applied only when buttons are not icon only. Note that the designs don't have the padding applied for icon-only buttons.
Use the iconOnly variable to conditionally add this padding.
Design
This PR
There was a problem hiding this comment.
I looked into this further; unfortunately this is adding padding to a second spot and will compound with the original padding already applied. I'll send an update.
I'll also send another update that will only add styles to one spot so there's no more confusion!
justinanastos
force-pushed
the
evans/add-button-padding
branch
from
976a325
to
d64815a
Compare
justinanastos
approved these changes
Aug 28, 2019
|
🚀 PR was released in v2.1.1 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Torres pointed out that the buttons did not expand to fit their contents, so this PR adds that padding (12px).