This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
AP-714 Use storybook docs #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinanastos
force-pushed
the
justin/storybook-docs
branch
5 times, most recently
from
b9d92ff to
b5b2e94
Compare
justinanastos
changed the title
justinanastos
force-pushed
the
justin/storybook-docs
branch
3 times, most recently
from
2c5f934 to
141d5c6
Compare
justinanastos
force-pushed
the
justin/storybook-docs
branch
from
141d5c6 to
8114dd6
Compare
2 tasks
justinanastos
force-pushed
the
justin/storybook-docs
branch
from
c60b02a to
917c8ce
Compare
justinanastos
changed the title
justinanastos
force-pushed
the
justin/storybook-docs
branch
3 times, most recently
from
31f8cf6 to
efb405b
Compare
|
Remove all use of |
justinanastos
force-pushed
the
justin/storybook-docs
branch
from
efb405b to
cef5a94
Compare
While these seem cool, they fail in two places:
1. They aren't tested with Chromatic besides the default
Well, nothing is tested with Chromatic now, but they will be when this
PR lands
2. They aren't very discoverable
For example, @danimann didn't know tables supported `density`. This is
where our docs will shine.
Lastly, the types aren't compatible with the new storybook betas so
good-bye 👋
…-typescript We're not using anything special that we can't get out of the box with @storybook/preset-typescript, so let's use it
The new storybook docs don't work with using `jsx` as the render pragma. Therefore, let's just use the less appealing `<ClassNames>` for now.
Storybook doesn't work with the css jsx pragma for some reason
justinanastos
force-pushed
the
justin/storybook-docs
branch
from
cef5a94 to
651567e
Compare
|
🚀 PR was released in v2.3.0 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like a cursory "let's get this out ASAP" review please. Leave all the comments you want, but please mark them as non-blocking (FYI, NBD) if they are not critical.
I had to call node in a funky way to allocate enough memory for storybook to build.
See storybookjs/storybook#7092 and storybookjs/storybook#7743