Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

Add onFocus prop to TextField type #84

Merged
merged 2 commits into from
Aug 27, 2019
Merged

Add onFocus prop to TextField type #84

merged 2 commits into from
Aug 27, 2019

Conversation

jgzuke
Copy link
Contributor

@jgzuke jgzuke commented Aug 27, 2019

We added onBlur before but not onFocus, I need this for one of our pages

@jgzuke jgzuke added the minor Increment the minor version when merged label Aug 27, 2019
justinanastos
justinanastos approved these changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@justinanastos justinanastos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor that I'd like to see. Also, please add a more descriptive title to the PR for the changelog and then merge it in

src/TextField/TextField.tsx Outdated Show resolved Hide resolved
@jgzuke jgzuke changed the title Add onFocus to type Add onFocus prop to Textfield type Aug 27, 2019
@jgzuke jgzuke changed the title Add onFocus prop to Textfield type Add onFocus prop to TextField type Aug 27, 2019
@jgzuke jgzuke merged commit 8d5e844 into master Aug 27, 2019
@jgzuke jgzuke deleted the jgzuke/add-on-change branch August 27, 2019 20:03
@justinanastos
Copy link
Contributor

🚀 PR was released in v2.1.0 🚀

@justinanastos justinanastos added the released This issue/pull request has been released. label Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@justinanastos justinanastos justinanastos approved these changes

Assignees
No one assigned
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgzuke @justinanastos