This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
WIP: Support for new graphql-js subscriptions support
#122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s both on client and server side using websockets as transport layer to be used on a new package called graphql-transport-ws. fix(NA): fixed path of new files.
feat(NA): applied changes according pull request review.. feat(NA): added static method for instance creation. refact(NA): change the class names back to subscriptionserver and subscriptionclient. feat(NA): applied changes according pull request review. feat(NA): added static method for instance creation. fix(NA): fixed error thrown when we try to print and query its already a string. refact(NA): change the class names back to subscriptionserver and subscriptionclient. feat(NA): added new helper function to fully extend network interface with ws transport. fix(NA): built legacy messages on server side and other bad object accesses. feat(NA): enclose wsclient creation inside addGraphQLWS function. fix(NA): removed useless addGraphQLWS function. feat(NA): added legacy support to the old server protocol.
feat(NA): added subscription function request. fix(NA): fixed unsubscribe function. feat(NA): added constructor verification for executor and schema. chore(NA): added correct comment inside on message function. feat(NA): added initial filtering for requests. feat(NA): added initial filtering for requests. fix(NA): changed way to store unsubscribe function. fix(NA): removed contextValue from serverOptions. fix(NA): correct warn comment when using legacy subscription manager, chore(NA): Implement Adapter pattern for executor refact(NA): refactor on ExecuteAdapters. feat(NA): added code to support formatError and formatResponse. fix(NA): fix way we invoke format functions. fix(NA): small changes on error creation and executor/subscriptionManager check on loadExecutor. fix(NA): fix bad usage of base params on execute. feat(NA): updated ws dependency to the last version. fix(NA): overrideDefaultErrorType might be undefined. fix(NA): support for legacy handler. fix(NA): fixed const and payload errors.
DxCx
reviewed
May 11, 2017
| rootValue?: any, | ||
| contextValue?: any, | ||
| variableValues?: { [key: string]: any }, | ||
| operationName?: string,) => Promise<ExecutionResult>; |
There was a problem hiding this comment.
Missing definition for SubscribeFunction
src/server.ts
Outdated
| operationName?: string, | ||
| ) => Promise<ExecutionResult>; | ||
|
|
||
| export interface Executor { |
There was a problem hiding this comment.
Executor shouldn't be remove, but subscribe should be added to it.
src/server.ts
Outdated
| operationName?: string, | ||
| ) => ({ | ||
| variableValues?: { [key: string]: any }, | ||
| operationName?: string,) => ({ | ||
| subscribe: (observer) => { | ||
| if (ExecuteAdapters.isASubscriptionRequest(document, operationName)) { | ||
| observer.error(new Error('Subscriptions are not supported')); |
There was a problem hiding this comment.
we should replace this with running subscribe, also pass subscribe (optional) to this funtion.
only if subscribe is not defined, throw this error
src/server.ts
Outdated
| }; | ||
| }, | ||
| }); | ||
| } | ||
|
|
||
| public static executeFromAsyncIteratorFunction(handlerFn: Function, execute: Function): ExecuteReactiveFunction { |
There was a problem hiding this comment.
and this is how to call subscribe and convert to observable :)
src/server.ts
Outdated
| this.execute = ExecuteAdapters.executeFromSubscriptionManager(subscriptionManager); | ||
| } else if ( executor.executeReactive ) { | ||
| this.execute = executor.executeReactive.bind(executor); | ||
| } else if (subscribe) { |
There was a problem hiding this comment.
executeReactive shouldn't be removed.. :\
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Based on
graphql-jswith support forsubscriptions(graphql/graphql-js#846) withAsyncIterator.This PR is based on @mistic PR: #108 and it will be merged along with his changes and the new package's API.
Changes
The main changes are support for
subscribeandexecutedirectly fromgraphql-jspackage, and manage the subscription/query/mutation (s).Also, transformation between the
AsyncIteratorreturned fromgraphql-jsto local implementation ofObservableand publish the result over the socket.Usage Example
With the new
graphql-jspackage, the usage with this transport is as follow: