Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not break too early when the filters doesn't match, check also children spans #13

Merged
merged 3 commits into from
May 2, 2022
Merged

fix: do not break too early when the filters doesn't match, check also children spans #13

merged 3 commits into from
May 2, 2022

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented May 2, 2022

No description provided.

@bnjjj
fix: do not break too early when the filters doesn't match, check als…
031f4fb 
…o children spans

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj requested a review from o0Ignition0o May 2, 2022 13:15
@bnjjj bnjjj self-assigned this May 2, 2022
@bnjjj bnjjj mentioned this pull request May 2, 2022
Closed
@bnjjj
add better config for cargo in circle ci
8d0dfca 
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj force-pushed the bnjjj/fix_filtering branch from b9b222e to 8d0dfca Compare May 2, 2022 13:20
o0Ignition0o
o0Ignition0o approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@o0Ignition0o o0Ignition0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome!
I was afraid wed have to track parent ids and everything but we don't actually record them.

LGTM :shipit:

@bnjjj
chore: upgrade version
a8a8aec 
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj merged commit eeba32b into main May 2, 2022
@bnjjj bnjjj mentioned this pull request May 2, 2022
Merged
@BrynCooke BrynCooke mentioned this pull request May 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@o0Ignition0o o0Ignition0o o0Ignition0o approved these changes

Assignees

@bnjjj bnjjj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnjjj @o0Ignition0o