Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove token management middleware? #247

Closed
stubailo opened this issue May 26, 2016 · 4 comments
Closed

Remove token management middleware? #247

stubailo opened this issue May 26, 2016 · 4 comments
Assignees

Comments

@stubailo
Copy link
Contributor

I'm not sure that having a token store built into Apollo Client is useful. I'm referring to this class: https://github.com/apollostack/apollo-client/blob/e8f22bd4b085637360eccb4745951987b11f0d2f/src/middleware.ts#L12

Just a sanity check here:

  1. In Meteor, you would get the token from Meteor directly
  2. When using cookies, you just store it in the browser
  3. Even when using custom tokens, you would want to cache them in local storage

Is the built in token storage thing that ships as part of the network interface useful?

Are you using it @jbaxleyiii @johnthepink?

@johnthepink
Copy link
Contributor

@stubailo you're right. It's not really that useful. It made sense with the initial way we intended to do our implementation. But I'm great with removing it now.

@stubailo
Copy link
Contributor Author

Sounds good - should be an easy issue to pick up for anyone interested!

@abhiaiyer91 abhiaiyer91 self-assigned this May 26, 2016
@abhiaiyer91
Copy link
Contributor

abhiaiyer91 commented May 29, 2016

PR #254

@Poincare
Copy link
Contributor

I think it is safe to close since the changes have been merged.

jbaxleyiii pushed a commit that referenced this issue Oct 17, 2017
…tools

Add Apollo Client Devtools to the Developer tools page
jbaxleyiii pushed a commit that referenced this issue Oct 18, 2017
Add documentation for the new connection directive
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants