Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AuthTokenMiddleware #254

Merged
merged 3 commits into from
May 30, 2016
Merged

Remove AuthTokenMiddleware #254

merged 3 commits into from
May 30, 2016

Conversation

abhiaiyer91
Copy link
Contributor

@abhiaiyer91 abhiaiyer91 commented May 29, 2016 •
edited
Loading

Remove AuthTokenMiddleware for issue #247
TODO:

  • Update CHANGELOG.md with your change
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@abhiaiyer91 abhiaiyer91 mentioned this pull request May 29, 2016
Closed
@Poincare
Copy link
Contributor

We should probably update the CHANGELOG since this is a user-facing change.

@stubailo
Copy link
Contributor

Looks great to me!

@Poincare
Copy link
Contributor

Travis CI failing on Node v5 for some reason?

@abhiaiyer91
Copy link
Contributor Author

Weird right. Tests run fine locally

@stubailo
Copy link
Contributor

Maybe some weird intermittent thing? Weird that the PR build passed. rerunning it.

@stubailo stubailo merged commit c45c31b into master May 30, 2016
@stubailo stubailo deleted the RemoveAuthTokenMiddleware branch September 20, 2016 03:43
jbaxleyiii pushed a commit that referenced this pull request Oct 17, 2017
@helfer
Merge pull request #254 from nandito/document_req_in_the_applymiddleware
b83c04d 
Add some extra info about the req parameter of the applyMiddleware
@cleancoindev cleancoindev mentioned this pull request May 11, 2022
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhiaiyer91 @Poincare @stubailo