AWS Lambda Integration #247

NeoReyad · 2016-12-17T03:56:47Z

This adds the AWS lambda integration for Apollo Server. This requires a Lambda function that is attached to an API Gateway using the Lambda Proxy Integration. I had to add another parameter to the server to pass in headers. Headers to allow cross origin calls cannot be set when using Lambda Proxy Integration mode and must be passed in when calling the callback function.

To allow for the tests to pass I had to mock out the req and res objects that are required by the test suite. I thought this was easier than copying all the tests. I still get errors printed out, from uncaught exceptions, still looking into why.

I will add an example and some documentation to the README file and complete all the todo tasks below.

Closes #101

TODO:

Update CHANGELOG.md with your change (include reference to issue & this PR)
Make sure all of the significant new logic is covered by tests
Rebase your changes on master so that they can be merged easily
Make sure all tests and linter rules pass

apollo-cla · 2016-12-17T03:56:47Z

@NeoReyad: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

dfischer · 2017-01-03T15:43:47Z

This is awesome.

DxCx

Good Job! Thanks!
this can be really awsome :P

DxCx · 2017-01-12T09:14:53Z

packages/graphql-server-lambda/package.json

+    "graphql-server-module-graphiql": "^0.4.3"
+  },
+  "devDependencies": {
+    "@types/aws-lambda": "0.0.5",


no dep (or peer-dep) for aws-lambda?
i'm not familiar with the node library so i'm not sure ;)

The typing library aws-lambda only provides type interfaces for the lambda function handler. It used when compiling typescript to ensure proper use of function parameters (event, context, and callback).

DxCx · 2017-01-12T09:16:14Z

packages/graphql-server-lambda/src/lambdaApollo.ts

+    throw new Error('Apollo Server requires options.');
+  }
+  if (!headers) {
+    headers = {};


can be done with default value on argument

also, i'm thinking maybe it will be better to keep the one argument convention like the other implementation, and just extend GraphQLOptions for Lambda, adding the optional headers
then the callback can also decide which headers to send back.

I agree, we should eliminate the headers options and stick with one argument. Will make this change.

DxCx · 2017-01-12T16:56:33Z

packages/graphql-server-lambda/tsconfig.json

+        "node_modules/@types"
+    ],
+    "types": [
+        "typed-graphql",


please remember to remove (since we moved to @types/graphql) when rebasing this.

Good catch thanks.

DxCx · 2017-01-19T17:33:54Z

hi @NeoReyad
version 0.5.1 is now out and there are quite few changes in integrations,
can you please rebase and align the integration package so we can merge it in?

DxCx · 2017-01-25T00:17:43Z

@helfer please review,
i'll probably rebase and merge tomorrow if we won't hear from @NeoReyad until then..

NeoReyad · 2017-01-25T00:55:54Z

Will Finnish up in a few hours. Just need to test get support and add some more documentation

DxCx · 2017-01-25T00:58:54Z

oh cool, thanks @NeoReyad! :)

DxCx

Thanks alot, looks amazing!
i can see the commit called WIP what are you still missing?
apart for small changes it looks pretty ready =)

DxCx · 2017-01-25T08:42:53Z

packages/graphql-server-lambda/tsconfig.json

+        "node_modules/@types"
+    ],
+    "types": [
+        "@types/graphql",


are you sure you need @types/graphql in here?
it think is requested as dep of core so you get's it from there..

DxCx · 2017-01-25T08:44:03Z

test/tests.js

@@ -8,3 +8,4 @@ require('../packages/graphql-server-hapi/dist/hapiApollo.test');
 require('../packages/graphql-server-koa/dist/koaApollo.test');
 require('../packages/graphql-server-restify/dist/restifyApollo.test');
 require('../packages/graphql-server-express/dist/apolloServerHttp.test');
+require('../packages/graphql-server-lambda/dist/lambdaApollo.test');


can you take that 1 line upper? :) apolloServerHttp is not integration test all modules are running but extra testing..

DxCx · 2017-01-25T08:45:26Z

packages/graphql-server-lambda/package.json

+  "devDependencies": {
+    "@types/aws-lambda": "0.0.5",
+    "@types/body-parser": "0.0.33",
+    "@types/multer": "0.0.32",


are you using multer & body-parser?
if not let's clear

DxCx · 2017-01-25T08:45:38Z

packages/graphql-server-lambda/package.json

+    "@types/aws-lambda": "0.0.5",
+    "@types/body-parser": "0.0.33",
+    "@types/multer": "0.0.32",
+    "@types/graphql": "^0.8.5",


you can already set to 0.8.6 ;)

DxCx · 2017-01-25T08:47:57Z

README.md

@@ -31,6 +31,7 @@ where variant is one of the following:
 - express
 - koa
 - hapi


that's not you, but i didn't noted it before.
can you add - restify as well?

NeoReyad · 2017-01-25T14:22:16Z

Thanks for review @DxCx. I will make the changes. I just want to update the readme of the graphql-server-lambda with basic instructions on how to deploy to lambda and test with get queires.

DxCx · 2017-01-25T15:36:21Z

oh cool no problem! 👍

DxCx · 2017-01-29T10:02:50Z

README.md

@@ -31,6 +31,7 @@ where variant is one of the following:
 - express
 - koa
 - hapi


DxCx · 2017-01-29T10:03:35Z

packages/graphql-server-lambda/package.json

+    "graphql-server-integration-testsuite": "^0.5.1"
+  },
+  "peerDependencies": {
+    "graphql": "^0.6.1 || ^0.7.0 || ^0.8.0"


please align with
#278

DxCx · 2017-01-29T10:04:13Z

packages/graphql-server-lambda/tsconfig.json

@@ -0,0 +1,25 @@
+{


please align with #281

DxCx · 2017-01-30T21:20:33Z

hi @NeoReyad we want to release a new package tomorrow with this PR inside,
can you take care of the last README.md you wanted to add?
or i'll just finish it up and merge, then you will open a new PR for the README?

NeoReyad · 2017-01-30T21:22:09Z

I will finish this tonight. I'm sorry about the delay have been busy.

DxCx · 2017-01-30T21:27:26Z

np @NeoReyad :)
thanks alot for the contribution,
i'll close this up, and you are free to open another PR for the README.md
sounds good?

NeoReyad · 2017-01-30T21:30:40Z

Let me just make sure it works. I think I had an issue with parsing the json, not catching an exception on empty string. Give me two hours Ill take a look at it right now.

NeoReyad · 2017-01-30T21:39:52Z

@DxCx If you want to merge it now that is fine and i can send pr for fix if i find one.

DxCx · 2017-01-30T21:53:26Z

Thanks,
planing on doing it tomorrow :)

Create an integration that will return a lambda handler for a graphql or graphiql server. This integration requires an API Gateway with Lambda Proxy Integration. The test runner expects req and res objects for testing. We have to mock these for the tests to execute properly.

Add example lambda handler and some documentation

NeoReyad · 2017-01-30T23:02:08Z

@DxCx Should be good to go. I had the headers as an array instead of an object. Will submit another PR for the documentation. But won't have time till later tonight.

This adds basic instructions to the README for deploying the lambda function. It uses the Serverless Application Model by creating a template that is used by the AWS CLI.

NeoReyad · 2017-01-31T05:57:34Z

Let me know if you want me to change anything else or update the instructions. Sorry about the delay

DxCx · 2017-01-31T07:56:05Z

wow @NeoReyad i was about to finish it now and seen you were done.
double thanks, @helfer let's merge and release 👍

helfer · 2017-02-01T02:46:40Z

This is great, thanks a lot @NeoReyad and @DxCx !

jangerhofer · 2017-02-17T04:07:37Z

Holy cow, this is killer! Not that I would cast any aspersions on Meteor, but this provides the nail in the coffin of replacing the Meteor stack as far as I am concerned.

Many thanks to you, @NeoReyad!

nicka · 2017-03-03T17:08:26Z

Would it be possible to get access to event.headers within the GraphQL context?

soda0289 · 2017-03-03T17:25:32Z

@nicka You might want to open an issue for more details. It is possible like this:

exports.graphqlHandler = function(event, context, callback)  {
    const headers = event.headers;
    server.graphqlLambda({ schema: myGraphQLSchema })(event, context, callback);
};

nicka · 2017-03-03T17:26:58Z

@soda0289 sorry for my stupidity haha, exactly what I needed! Thanks 👍

jangerhofer · 2017-03-19T01:22:08Z

So that covers the request headers, but how does one set response headers? I tried to setup an Apollo client w/ CORS (from my website to the AWS API Gateway URL) but couldn't figure out how to set the "Access-Control-Allow-Origin" header without hard-coding it into the success condition of this library like so: headers['Access-Control-Allow-Origin'] = '*';

Is there an easy option I can pass and I'm missing something? Should I submit a PR to make this less hacky?

soda0289 · 2017-03-19T01:45:16Z

@jangerhofer
This has been discussed in this issue:
#315

I have been meaning to update the documentation or do you think we should allow an option to pass through custom headers. It might be possible to add the headers with the api gateway response mapping but I'm not sure you can do that with the proxy integration.

Siyfion · 2017-06-16T09:25:11Z

@NeoReyad Do you think it might be worth converting the docs (or adding to them) to use Serverless (https://serverless.com/) as it will make the whole process just that much easier and simpler to get started?

soda0289 · 2017-06-16T13:46:06Z

I've been meaning to do this for a while. I will try and get to it this week.

There is a config here if that helps:
#332 (comment)

Siyfion · 2017-06-16T13:53:53Z

Yup, that's pretty much what I ended up with!

Siyfion · 2017-08-09T13:59:42Z

@soda0289 / @NeoReyad / @DxCx are any of you having issues getting this to work on Lambda with Node v6.10? I have a situation whereby the whole application is working perfectly in serverless offline but when I deploy, the authorizer function runs, then the GraphQL code just times-out after my maximum is reached (10secs).

soda0289 · 2017-08-09T14:02:44Z

@Siyfion There is an issue open here #456 which suggests that the Lambda function will not respond. If we set callbackWaitsForEmptyEventLoop to true it will respond as soon as the callback is called. You can try setting this in your callback. Let me know if that helps or if you need some sample code

Siyfion · 2017-08-09T14:07:17Z

Wow! 😮 Fastest response ever award, goes to @soda0289! Cheers, and yes, that looks almost certainly like the issue I am facing!

NeoReyad force-pushed the lambda-support branch from 05a10f0 to 5cd4e7f Compare December 17, 2016 04:11

NeoReyad changed the title ~~Lambda support~~ AWS Lambda Integration Dec 17, 2016

NeoReyad force-pushed the lambda-support branch from 5ba7d42 to fa48655 Compare December 17, 2016 05:46

DxCx reviewed Jan 12, 2017

View reviewed changes

DxCx added tag: new feature 🛫 in-progress and removed ready labels Jan 12, 2017

NeoReyad force-pushed the lambda-support branch 2 times, most recently from 076f756 to 961275b Compare January 12, 2017 16:31

DxCx reviewed Jan 12, 2017

View reviewed changes

NeoReyad force-pushed the lambda-support branch from 961275b to 55a5ea5 Compare January 13, 2017 02:03

NeoReyad force-pushed the lambda-support branch from 55a5ea5 to d96db0e Compare January 24, 2017 23:44

NeoReyad force-pushed the lambda-support branch from d96db0e to 82c3e0e Compare January 25, 2017 05:31

DxCx suggested changes Jan 25, 2017

View reviewed changes

NeoReyad force-pushed the lambda-support branch from 82c3e0e to dc8a1fd Compare January 25, 2017 19:11

DxCx suggested changes Jan 29, 2017

View reviewed changes

NeoReyad added 3 commits January 30, 2017 16:58

Update README and Changelog

e5f6954

Add example lambda handler and some documentation

Add the restify variant to README

c2c42c0

NeoReyad force-pushed the lambda-support branch from 6f1110a to c2c42c0 Compare January 30, 2017 23:00

Add instructions for deploying the Lambda Function

f48a352

This adds basic instructions to the README for deploying the lambda function. It uses the Serverless Application Model by creating a template that is used by the AWS CLI.

DxCx approved these changes Jan 31, 2017

View reviewed changes

Merge branch 'master' into lambda-support

95b1356

helfer merged commit 836472b into apollographql:master Feb 1, 2017

helfer removed the 🛫 in-progress label Feb 1, 2017

trevor-scheer pushed a commit that referenced this pull request May 6, 2020

chore(deps): update dependency @types/jest to v24.0.23 (#247)

3f67d1a

trevor-scheer pushed a commit that referenced this pull request May 14, 2020

chore(deps): update dependency @types/jest to v24.0.23 (#247)

e8eadeb

github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023

@@ @@ -31,6 +31,7 @@ where variant is one of the following: @@
                - express
                - koa
                - hapi

AWS Lambda Integration #247

AWS Lambda Integration #247

Conversation

NeoReyad commented Dec 17, 2016 • edited by DxCx Loading

apollo-cla commented Dec 17, 2016

dfischer commented Jan 3, 2017

DxCx left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DxCx commented Jan 19, 2017

DxCx commented Jan 25, 2017

NeoReyad commented Jan 25, 2017

DxCx commented Jan 25, 2017

DxCx left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NeoReyad commented Jan 25, 2017

DxCx commented Jan 25, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DxCx commented Jan 30, 2017

NeoReyad commented Jan 30, 2017

DxCx commented Jan 30, 2017

NeoReyad commented Jan 30, 2017

NeoReyad commented Jan 30, 2017

DxCx commented Jan 30, 2017

NeoReyad commented Jan 30, 2017

NeoReyad commented Jan 31, 2017

DxCx commented Jan 31, 2017 • edited Loading

helfer commented Feb 1, 2017

jangerhofer commented Feb 17, 2017 • edited Loading

nicka commented Mar 3, 2017

soda0289 commented Mar 3, 2017

nicka commented Mar 3, 2017

jangerhofer commented Mar 19, 2017 • edited Loading

soda0289 commented Mar 19, 2017

Siyfion commented Jun 16, 2017 • edited Loading

soda0289 commented Jun 16, 2017

Siyfion commented Jun 16, 2017

Siyfion commented Aug 9, 2017 • edited Loading

soda0289 commented Aug 9, 2017

Siyfion commented Aug 9, 2017

NeoReyad commented Dec 17, 2016 •

edited by DxCx

Loading

DxCx commented Jan 31, 2017 •

edited

Loading

jangerhofer commented Feb 17, 2017 •

edited

Loading

jangerhofer commented Mar 19, 2017 •

edited

Loading

Siyfion commented Jun 16, 2017 •

edited

Loading

Siyfion commented Aug 9, 2017 •

edited

Loading