New: Added iproute from trireme-lib to netlink-go #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitlimaye
suggested changes
May 2, 2018
iproute/helpers.go
Outdated
| return buf | ||
| } | ||
|
|
||
| func send(buf []byte) error { |
There was a problem hiding this comment.
Don't we have this function in our common library. Socket Send should be identical in all netlink packages.
(I think only the flags and family will change)
iproute/iproute.go
Outdated
| maskbuf := markMaskAttrToWire(uint32(rule.Mask)) | ||
| nlmsghdr.Len = syscall.SizeofNlMsghdr + uint32(len(rtmsgbuf)+len(priobuf)+len(markbuf)+len(maskbuf)) | ||
| buf := common.SerializeNlMsgHdr(nlmsghdr) | ||
|
|
There was a problem hiding this comment.
Make a variadic function allocate slice once and copy data.
Multiple appends here are not great and the same code is present in all functions
added 16 commits
May 2, 2018 11:56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--> This PR adds iproute package from trireme-lib
--> Added interfaces for testing
--> Added mock for socket functions
--> Added unit tests for iproute
--> https://github.com/aporeto-inc/enforcerd/pull/577