Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont user hmark for legacy acls #1019

Open
wants to merge 1 commit into
base: release-3.13.0
Choose a base branch
from
Open

Conversation

amitlimaye
Copy link
Contributor

Description

Changes proposed in this pull request.

Test plan

Outline the test plan used to test this change before merging it.

Fixes #.

@aporeto-bot
Copy link
Collaborator

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1634",
    "commit-sha": "3e01b1cd9704df5f62b58ffdaea1aad194d55c1b",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "1019",
    "commit-sha": "f6b4263850a4b41008b7daab00ec1cf269b8057a",
    "pipeline": "master"
  }
]

@codecov
Copy link

codecov bot commented Mar 28, 2020

Codecov Report

Merging #1019 into release-3.13.0 will increase coverage by <.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-3.13.0    #1019      +/-   ##
==================================================
+ Coverage           57.96%   57.97%   +<.01%     
==================================================
  Files                 112      112              
  Lines               11453    11454       +1     
==================================================
+ Hits                 6639     6640       +1     
  Misses               4194     4194              
  Partials              620      620
Impacted Files Coverage Δ
...ontroller/internal/supervisor/iptablesctrl/acls.go 65.18% <0%> (ø) ⬆️
...ller/internal/supervisor/iptablesctrl/templates.go 88.43% <100%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aa5b86...f6b4263. Read the comment docs.

@aporeto-bot
Copy link
Collaborator

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1634",
    "commit-sha": "3e01b1cd9704df5f62b58ffdaea1aad194d55c1b",
    "pipeline": "release-3.13."
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "1019",
    "commit-sha": "f6b4263850a4b41008b7daab00ec1cf269b8057a",
    "pipeline": "release-3.13."
  }
]

@aporeto-bot
Copy link
Collaborator

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1634",
    "commit-sha": "3e01b1cd9704df5f62b58ffdaea1aad194d55c1b",
    "pipeline": "release-3.13.0"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "1019",
    "commit-sha": "f6b4263850a4b41008b7daab00ec1cf269b8057a",
    "pipeline": "release-3.13.0"
  }
]

1 similar comment
@aporeto-bot
Copy link
Collaborator

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1634",
    "commit-sha": "3e01b1cd9704df5f62b58ffdaea1aad194d55c1b",
    "pipeline": "release-3.13.0"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "1019",
    "commit-sha": "f6b4263850a4b41008b7daab00ec1cf269b8057a",
    "pipeline": "release-3.13.0"
  }
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants