Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pypi release #3476

Merged
merged 1 commit into from
Apr 28, 2023
Merged

fix pypi release #3476

merged 1 commit into from
Apr 28, 2023

Conversation

BumbleFeng
Copy link
Contributor

latest urllib3 version 2.0.0 does not work with requests. psf/requests#6432

@BumbleFeng
fix pypi release
40b4793 
Signed-off-by: Feng Huang <fehuang@redhat.com>
hemslo
hemslo approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@hemslo hemslo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! I wish we have a better dependency manager with containerised run for these tasks.

@BumbleFeng BumbleFeng merged commit e3c5009 into app-sre:master Apr 28, 2023
@BumbleFeng BumbleFeng deleted the fix branch April 28, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rporres rporres rporres approved these changes

@hemslo hemslo hemslo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BumbleFeng @hemslo @rporres