[terraform-resources] support RDS delete #4723
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maorfr
force-pushed
the
tfr-rds-delete
branch
from
90ce7f1 to
157a6a1
Compare
patjlm
approved these changes
Oct 14, 2024
maorfr
force-pushed
the
tfr-rds-delete
branch
from
157a6a1 to
0a85773
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on app-sre/qontract-schemas#683
similar to #4521
the
deleteapproach is cleaner for RDS upgrades which require deleting read replicas. also, consistency is good.