Skip to content
This repository has been archived by the owner on Aug 14, 2020. It is now read-only.

vendor: added missing golang.org/x/net #238

Closed
wants to merge 1 commit into from

Conversation

cgonyeo
Copy link
Member

@cgonyeo cgonyeo commented Jan 24, 2017

I was trying to add a package via glide for a feature, and glide kept breaking due to missing packages from golang.org/x/net. I've added that package to glide.yaml and then ran glide up -v and glide vc --only-code --no-tests

@lucab
Copy link
Contributor

lucab commented Jan 25, 2017

I think something went horribly wrong in here, but I'm not sure what. It seems to be pulling in weird things like aws-sdk, jose and grpc. I re-did the original go-digest add in #238 (via scripts/glide-update) and seems much saner. Can you try to build on top of that? I think the root of most issues around glide here is that appc imports kubernetes.

@cgonyeo
Copy link
Member Author

cgonyeo commented Jan 25, 2017

Closed in favor of @lucab's PR

@cgonyeo cgonyeo closed this Jan 25, 2017
@cgonyeo cgonyeo deleted the fix-vendoring branch January 25, 2017 18:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants