Skip to content
This repository has been archived by the owner on Aug 14, 2020. It is now read-only.

discovery: increase default connection timeout #644

Merged
merged 1 commit into from
Aug 4, 2016

Conversation

lucab
Copy link
Contributor

@lucab lucab commented Aug 2, 2016

This commit increases default connection timeout from 5s to 20s,
in order to gracefully accomodate for retrials. This will help in
overcoming soft-failure cases, like skipping a single faulty
resolvers in resolv.conf.

This is still a quite aggressive timeout, well below the Linux
timeout of 127s for new TCP connections.

This commit increases default connection timeout from 5s to 20s,
in order to gracefully accomodate for retrials. This will help in
overcoming soft-failure cases, like skipping a single faulty
resolvers in resolv.conf.

This is still a quite aggressive timeout, well below the Linux
timeout of 127s for new TCP connections.
@lucab
Copy link
Contributor Author

lucab commented Aug 2, 2016

Coming from rkt/rkt#3009 (comment)

There is still some room for increase here, but I'm not sure about why the original value was picked so low (and #112 lacks a bit of context). For reference, nginx has 30s timeout just for DNS resolution while default Linux tcp_syn_retries result in 127s timeout for new connections.

@iaguis
Copy link
Member

iaguis commented Aug 2, 2016

This looks reasonable to me (LRTM?)

@lucab
Copy link
Contributor Author

lucab commented Aug 4, 2016

@jonboulle may have some insights here.

@jonboulle
Copy link
Contributor

LRTM

@jonboulle jonboulle merged commit 737c544 into appc:master Aug 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants