This repository has been archived by the owner on Aug 14, 2020. It is now read-only.
CRI: add oom_score_adj isolator #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucab
reviewed
Sep 23, 2016
| tests := []struct { | ||
| in []string | ||
|
|
||
| wset []LinuxCapability |
There was a problem hiding this comment.
I guess you forgot to wire in the new tests.
There was a problem hiding this comment.
Oops, this test wasn't needed - I forgot to delete it.
There was a problem hiding this comment.
This test and the JSON one exercise slightly different codepaths, can you just bring it back and adapt?
There was a problem hiding this comment.
The codepath tested here doesn't exist for the OOM case, because it's a scalar / simple value.
|
LGTM |
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for rkt/rkt#3203
@lucab please review?