This repository has been archived by the owner on Aug 14, 2020. It is now read-only.
spec/ace: Specify Content-Type for metadata service. #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the metadata service endpoints explicitly specify a Content-Type of text/plain; charset=us-ascii. For most other endpoints, the ACE validator expects a Content-Type of application/json. The one exception is the HMAC verify endpoint which makes no mention of its Content-Type nor even the contents of its response body. The current implementation in `rkt` sets the Content-Type to text/plain; charset=us-ascii which is now reflected in the spec.
|
LGTM, thanks (I was wondering whether these should be in backticks, as you've done in the commit message, but can see arguments either way, so will leave it for now - feel free to follow up if you want to change that). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the metadata service endpoints explicitly specify a
Content-Type of
text/plain; charset=us-ascii. For most otherendpoints, the ACE validator expects a Content-Type of
application/json.The one exception is the HMAC verify endpoint which makes no mention
of its Content-Type nor even the contents of its response body. The
current implementation in
rktsets the Content-Type totext/plain; charset=us-asciiwhich is now reflected in the spec.