Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add HasManyFields2 #1107

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

jupp0r
Copy link

@jupp0r jupp0r commented Nov 5, 2022

This change adds HasManyfields2, a successor to HasManyFields that is more composable and easier to integrate with state management libraries like mobx and easier to adopt to server-side rendering and dynamic hydration (compared to HasManyfields).

This change adds HasManyfields2, a successor to HasManyFields that is more composable
and easier to integrate with state management libraries like mobx and easier to
adopt to server-side rendering and dynamic hydration (compared to HasManyfields).
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2022

Released prerelease version 7.9.1-has-many-pains-with-tooltips-9d2cc4c.0.
You may now run npm install @appfolio/react-gears@has-many-pains-with-tooltips

@aaronmars
Copy link
Contributor

Might this be more appropriate over in react-libs (the 'components' project within that monorepo).

@jupp0r
Copy link
Author

jupp0r commented Nov 9, 2022

Might this be more appropriate over in react-libs (the 'components' project within that monorepo).

You tell me :) what's the plan for adoption of react-libs? Can somebody use it right now it APM? People have been asking for HasManyFields2 in APM a few times and it took us pretty long to get this ready, so it would be great if people could start using it. Having it in both might also be an option?

@aaronmars
Copy link
Contributor

Can somebody use it right now it APM?

For sure! I have yet to do it, but I'm in the middle of the first migration of react-gears List to react-components List.
The library should be all ready to go, though.
One benefit (if you choose to exercise it) is that you can keep the name as HasManyFields since it's in a completely new library.
I can definitely help with the move from react-gears to react-components

@steventhan steventhan force-pushed the master branch 5 times, most recently from fc7b9c2 to 440bf24 Compare April 7, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants