Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Apple Pay Button #17

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

KyleG43
Copy link

@KyleG43 KyleG43 commented May 21, 2024

Add back removed button types for backwards compatibility, remove default height, set default minWidth and minHeight to minimum values allowed by Apple, update docs

@kermitapp
Copy link

kermitapp bot commented May 21, 2024

@KyleG43 KyleG43 force-pushed the COLD-448-replace-removed-button-types branch 5 times, most recently from 5fabf09 to 9e03cd1 Compare May 21, 2024 18:29
Copy link

@LeadFreeCandy LeadFreeCandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a few small things, this look good overall to me

ios/Views/PKPaymentButtonView.m Show resolved Hide resolved
ios/Views/PKPaymentButtonView.m Show resolved Hide resolved
docs/ApplePayButton.md Show resolved Hide resolved
js/PKPaymentButton/index.js Show resolved Hide resolved
Copy link

@sethvanb sethvanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you for doing this work

@KyleG43 KyleG43 requested a review from trcoffman May 29, 2024 22:01
@trcoffman trcoffman self-requested a review June 5, 2024 22:05
@KyleG43 KyleG43 force-pushed the COLD-448-replace-removed-button-types branch from 9e03cd1 to 7fa4f58 Compare June 5, 2024 22:59
Add back original button types, set default min width and min height,
remove default height, update docs
@KyleG43 KyleG43 force-pushed the COLD-448-replace-removed-button-types branch from 7fa4f58 to 06d3308 Compare June 5, 2024 23:04
Copy link

@dvicory dvicory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@trcoffman trcoffman merged commit 78d273f into master Jun 5, 2024
2 checks passed
@KyleG43 KyleG43 deleted the COLD-448-replace-removed-button-types branch June 5, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants