-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Apple Pay Button #17
Conversation
Jira Issue: https://appfolio.atlassian.net/browse/COLD-448 |
5fabf09
to
9e03cd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than a few small things, this look good overall to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank you for doing this work
9e03cd1
to
7fa4f58
Compare
Add back original button types, set default min width and min height, remove default height, update docs
7fa4f58
to
06d3308
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Add back removed button types for backwards compatibility, remove default height, set default minWidth and minHeight to minimum values allowed by Apple, update docs