-
Notifications
You must be signed in to change notification settings - Fork 136
Open
Description
In the recent issue #3298 we introduced new user roles while keeping the logic the same as it is. We just made the new roles behaves same as old roles.
Now as we've released that part we can move forward and make the code behave depend on the role more specific.
What can be done:
- Let only invite users with the exact roles (not like any manager user can be invited with any manager role). Related code https://github.com/topcoder-platform/tc-project-service/blob/feature/new-roles/src/routes/projectMemberInvites/create.js#L290-L307
- Restrict users so they can join project using Join button, only with their role (not like any manager user can be invited with any manager role). See conversation on this PR New user roles topcoder-platform/tc-project-service#387. Most likely it's already done on the Project Service with some additional permissions for some roles, see related code https://github.com/topcoder-platform/tc-project-service/blob/dev/src/routes/projectMembers/create.js#L43-L95. We may want to update these rules with a more consistent approach or some general logic here. We also have to restrict which roles managers can choose when joining the project themselves in the joining dialog. Client-side should be aligned with the server-side.
- Send more precise user role to the analytic system. See comment https://github.com/appirio-tech/connect-app/blob/feature/new-roles/src/actions/loadUser.js#L58-L68