chore(ci): try to pin opencv version to something that will work

appium-boneyard · Jan 11, 2022 · db9976e · db9976e
1 parent c3020f0
commit db9976e
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -11,7 +11,9 @@ on:
 jobs:
   build:
     runs-on: ubuntu-latest
-
+    env:
+      OPENCV4NODEJS_AUTOBUILD_OPENCV_VERSION: 3.4.16
+      OPENCV_BUILD_ROOT: ~/opencv
     steps:
       - name: Node Setup
         uses: actions/setup-node@v2.5.0
@@ -38,7 +40,7 @@ jobs:
 
         # don't waste 20 minutes installing opencv if we don't get past lint
       - name: E2E Install
-        run: npm install opencv4nodejs
+        run: npm install @u4/opencv4nodejs
 
       - name: Unit Tests
         run: npm run test:unit

diff --git a/packages/images/README.md b/packages/images/README.md
@@ -11,6 +11,7 @@ This is an official Appium plugin designed to facilitate image comparison, visua
 
 * [OpenCV](https://opencv.org) 3.x native libraries
 * [opencv4nodejs](https://github.com/justadudewhohacks/opencv4nodejs) NPM module: install with `npm i -g opencv4nodejs`. By default the preinstall script of this module also downloads and makes all the required OpenCV libs from source, but this requires developer tools to be available on the host system.
+* NOTE: The [@u4/opencv4nodejs](https://github.com/UrielCh/opencv4nodejs) fork of opencv4nodejs seems to be more maintained and functional for most users.
 * Appium Server 2.0+
 
 ## Installation - Server

diff --git a/packages/images/package.json b/packages/images/package.json
@@ -33,7 +33,7 @@
   "dependencies": {
     "@appium/base-driver": "8.2.1",
     "@appium/base-plugin": "^1.8.0",
-    "@appium/support": "2.55.2",
+    "@appium/support": "2.55.3",
     "lru-cache": "6.0.0"
   },
   "scripts": {

diff --git a/packages/images/test/unit/plugin-specs.js b/packages/images/test/unit/plugin-specs.js
@@ -1,6 +1,6 @@
 let hasOpenCV = false;
 try {
-  require('opencv4nodejs');
+  require('@u4/opencv4nodejs');
   hasOpenCV = true;
 } catch (ign) {}