grant and revoke app permission for Android 23 and above #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlipps
requested changes
Nov 30, 2016
There was a problem hiding this comment.
Just a few small things. Overall looks amazing. Thanks @sravanmedarapu!
|
|
||
| async function cleanUpReqPermissions (reqPermissions) { | ||
| let permissions = []; | ||
| Array.from(reqPermissions).forEach(function (permission) { |
There was a problem hiding this comment.
I'd rewrite this function's body as:
return reqPermissions
.filter(p => p.trim().startsWith('android.permission'))
.map(p => p.trim().replace(': granted=true', ''));| let args = ['dump', 'badging', localApk]; | ||
| let {stdout} = await exec(this.binaries.aapt, args); | ||
| let targetSdkVersion = new RegExp(/targetSdkVersion:'([^']+)'/g).exec(stdout); | ||
| return parseInt(targetSdkVersion[1]); |
There was a problem hiding this comment.
parseInt(targetSdkVersion[1], 10);did you run lint on this? this should have been caught
| await adb.install(apiDemos); | ||
| (await adb.isAppInstalled('io.appium.android.apis')).should.be.true; | ||
| let requestedPermissions = await adb.getReqPermissions('io.appium.android.apis'); | ||
| expect(await adb.getReqPermissions('io.appium.android.apis')).to.have.members(requestedPermissions); |
There was a problem hiding this comment.
I'm not sure if this is testing anything. What it seems to be doing is ensuring that calling getReqPermissions twice returns the same thing. Is that what you want to be testing?
sravanmedarapu
force-pushed
the
master
branch
from
7ef7f21
to
f2876e6
Compare
jlipps
approved these changes
Dec 1, 2016
|
Published as 2.8.0 |
|
had a problem publishing from the plane, it's actually 2.9.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #appium/appium#5561
cc: @jlipps, @imurchie