feat: Bump Eslint #781
feat: Bump Eslint #781
Conversation
Bumps [@appium/eslint-config-appium-ts](https://github.com/appium/appium/tree/HEAD/packages/eslint-config-appium-ts) from 0.3.3 to 1.0.1. - [Release notes](https://github.com/appium/appium/releases) - [Changelog](https://github.com/appium/appium/blob/master/packages/eslint-config-appium-ts/CHANGELOG.md) - [Commits](https://github.com/appium/appium/commits/@appium/eslint-config-appium-ts@1.0.1/packages/eslint-config-appium-ts) --- updated-dependencies: - dependency-name: "@appium/eslint-config-appium-ts" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
| import type { LRUCache } from 'lru-cache'; | ||
| import type { ExecError } from 'teen_process'; | ||
| import type { StringRecord } from '@appium/types'; |
There was a problem hiding this comment.
Won't this require changing @appium/types from a dev dependency to a production dependency?
There was a problem hiding this comment.
moved to depenncies
| @@ -107,7 +107,7 @@ function formatFilterSpecs (filterSpecs) { | |||
| } | |||
|
|
|||
|
|
|||
| class Logcat extends EventEmitter { | |||
| export class Logcat extends EventEmitter { | |||
There was a problem hiding this comment.
Since the main index.ts file has export type * from './lib/logcat', it will now also export the Logcat type. It's probably fine but worth pointing out.
| export type * from './lib/mixins'; | ||
| export type * from './lib/tools'; | ||
| // eslint-disable-next-line import/export | ||
| export {getAndroidBinaryPath} from './lib/tools/system-calls'; |
There was a problem hiding this comment.
This export looks a bit out of place in this file; maybe it could be moved back to ./lib/adb?
There was a problem hiding this comment.
I wanted to make it more explicit
There was a problem hiding this comment.
perhaps export * from './lib/adb'; is also suboptimal. We need to be explicit about what we export
| @@ -166,7 +164,7 @@ function getSdkBinaryLocationCandidates (sdkRoot, fullBinaryName) { | |||
| * of known locations or Android SDK is not installed on the | |||
| * local file system. | |||
| */ | |||
| async function getAndroidBinaryPath (binaryName) { | |||
| export async function getAndroidBinaryPath (binaryName) { | |||
| const fullBinaryName = getBinaryNameForOS(binaryName); | |||
There was a problem hiding this comment.
Should this be _getBinaryNameForOS? Or was it originally incorrect?
There was a problem hiding this comment.
this one is memoized, which is what we want
|
Checked the method/property names, all look correct 👍 |
## [12.8.0](v12.7.4...v12.8.0) (2025-01-05) ### Features * Bump Eslint ([#781](#781)) ([9613100](9613100))
|
🎉 This PR is included in version 12.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Eslint update also required to update the mixin logic, so the linter does not get confused too much by previous hacks.
Please check carefully if all method and property names are properly preserved because there are many and typos are possible.