Allow execution of mobile:shell if relaxed security is enabled for the driver #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imurchie
approved these changes
Dec 14, 2017
|
|
||
| commands.mobileShell = async function (opts = {}) { | ||
| if (!this.relaxedSecurityEnabled) { | ||
| log.errorAndThrow(`Appium server must have relaxed security flag set in order to run any shell commands`); |
There was a problem hiding this comment.
Should this mention the actual name of the flag?
There was a problem hiding this comment.
the name is anyway mentioned in the documentation. Plus less work for us if we decide to change argument's name
dpgraham
approved these changes
Dec 14, 2017
| await driver.execute('mobile: shell', {command: 'pm', args: ['list']}) | ||
| .should.eventually.be.rejectedWith(/must have relaxed security flag set/); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Are we able to add a test that successfully executes a shell command?
There was a problem hiding this comment.
you read my mind :-P
This was referenced Dec 14, 2017
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is ok for clients to have access to extended possibilities if Appium server is running on their side.