fix: calls this.opts for createBaseADB #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/commands/device/common.js
Outdated
| // @ts-expect-error do not put arbitrary properties on opts | ||
| const {udid, emPort} = opts ?? {}; | ||
| const adb = await createBaseADB(opts); | ||
| const {udid, emPort} = this.opts ?? {}; |
There was a problem hiding this comment.
this.opts are always defined so the ?? part does not do anything
lib/commands/device/common.js
Outdated
| @@ -130,10 +130,10 @@ export async function getDeviceInfoFromCaps() { | |||
| * @property {(AndroidDriverOpts & {emPort?: number})?} [opts=null] | |||
There was a problem hiding this comment.
docs need to be updated
mykola-mokhnach
approved these changes
Jan 26, 2024
|
with this fix: |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 26, 2024
## [8.1.6](v8.1.5...v8.1.6) (2024-01-26) ### Bug Fixes * calls this.opts for createBaseADB ([#908](#908)) ([8ed666a](8ed666a))
|
🎉 This PR is included in version 8.1.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
appium-android-driver/lib/commands/device/common.js
Line 22 in 884c0bc
appium/appium#19713
Actually, when I saw logs in the ruby_lib_core's test Appium log, it had:
but tests worked.
Testing in appium/ruby_lib_core#520
hm, I used GitHub Codespase, then auto linter was applied...