viewtag selector strategy #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgraham
force-pushed
the
dpgraham-view-selector
branch
from
cf55c92 to
b9e3dc1
Compare
| @Nullable | ||
| public String getViewTag() { | ||
| Object tag = view.getTag(); | ||
| if (tag != null) { |
There was a problem hiding this comment.
return tag == null ? null : tag.toString()
| @@ -179,6 +182,9 @@ public void describeTo(Description description) { | |||
| views = getViews(root, withXPath(selector), false); | |||
| } | |||
| break; | |||
| case VIEW_TAG: | |||
| views = getViews(root, withTagValue(allOf(instanceOf(String.class), equalTo((Object) selector))), findOne); | |||
There was a problem hiding this comment.
why findOne? Cannot it be that two views have the same tag?
There was a problem hiding this comment.
findOne is a boolean variable... if it's false it will look for multiple instances.
There was a problem hiding this comment.
Probably should've be called shouldFindOne
This was referenced Aug 8, 2018
This was referenced Aug 8, 2018
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add custom selector that targets elements by the View Tag
(related to: appium/appium#6025)