Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update workflow & build system #595

Closed
wants to merge 3 commits into from
Closed

feat: update workflow & build system #595

wants to merge 3 commits into from

Conversation

boneskull
Copy link
Contributor

This PR:

  • Removes Babel, pre-commit
  • Replaces with TypeScript and husky, respectively
  • Disables dependabot in lieu of renovate
  • Ships type definitions
  • Updates dependencies and commits package-lock.json
  • Update eslint config (and a small bit of linting)

@boneskull boneskull added enhancement dependencies Pull requests that update a dependency file labels Apr 18, 2023
@boneskull boneskull self-assigned this Apr 18, 2023
@boneskull
Copy link
Contributor Author

This is in prep for:

  1. Converting this driver to use Execute Methods instead of its handrolled system, then
  2. Migrating command documentation into the source docstrings
  3. Auto-generating documentation from sources

@boneskull
feat: update workflow & build system
de359bd 
This PR:

- Removes Babel, `pre-commit`
- Replaces with TypeScript and `husky`, respectively
- Disables dependabot in lieu of renovate
- Ships type definitions
- Updates dependencies and commits `package-lock.json`
- Update eslint config (and a small bit of linting)
@boneskull
Copy link
Contributor Author

I can do this conversion in 30m now 😜

jlipps
jlipps approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@jlipps jlipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when CI is happy

@boneskull
Copy link
Contributor Author

closing in lieu of #635

@boneskull boneskull closed this Jul 5, 2023
@boneskull boneskull deleted the boneskull/ts branch July 5, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlipps jlipps jlipps approved these changes

@KazuCocoa KazuCocoa Awaiting requested review from KazuCocoa

@mykola-mokhnach mykola-mokhnach Awaiting requested review from mykola-mokhnach

Assignees

@boneskull boneskull

Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boneskull @jlipps