Add an endpoint for getting battery information #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmaxim
reviewed
Apr 29, 2018
| final Intent batteryStatus = getBatteryStatusIntent(); | ||
| final int level = batteryStatus.getIntExtra(BatteryManager.EXTRA_LEVEL, -1); | ||
| final int scale = batteryStatus.getIntExtra(BatteryManager.EXTRA_SCALE, -1); | ||
| return level * 1.0 / scale; |
added 2 commits
April 30, 2018 07:26
imurchie
approved these changes
Apr 30, 2018
KazuCocoa
reviewed
May 1, 2018
| .getTargetContext()); | ||
| try { | ||
| response.put("level", batteryHelper.getLevel()); | ||
| response.put("status", batteryHelper.getStatus()); |
There was a problem hiding this comment.
Can we change the response name of status to state like iOS?
Since when I implemented it in Ruby client, I faced appium/ruby_lib_core#85 (comment) error and it failed to parse status as an error code of JsonWiredProtocol.
There was a problem hiding this comment.
I just wanted to keep system-specific terminology. In Android this indicator is called STATUS
There was a problem hiding this comment.
if we can, it'd be nice to have cross-platform compatibility for the API. is that possible here?
There was a problem hiding this comment.
ok, let's call is state
There was a problem hiding this comment.
ok, I'll rename that property on driver level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just because this was requested