Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce videoFilters screen recording parameter #1005

Merged
merged 2 commits into from
Jul 13, 2019

Conversation

mykola-mokhnach
Copy link
Contributor

This might be useful for advanced source stream transformations, like rotation. See https://discuss.appium.io/t/video-is-not-capturing-in-landscape-mode-while-running-appium-script-in-ipad/26738/8

args.push('-vf', `scale=${this.opts.videoScale}`);
const {protocol, hostname} = url.parse(remoteUrl);
args.push('-i', `${protocol}//${hostname}:${remotePort}`);
if (videoFilters || videoScale) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@mykola-mokhnach mykola-mokhnach merged commit ae39b45 into appium:master Jul 13, 2019
@mykola-mokhnach mykola-mokhnach deleted the filter branch July 13, 2019 06:29
khanayan123 pushed a commit to khanayan123/appium-xcuitest-driver that referenced this pull request May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants