Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: no actions in w3c actions case #2432

Merged
merged 7 commits into from
Jul 20, 2024
Merged

fix: no actions in w3c actions case #2432

merged 7 commits into from
Jul 20, 2024

Conversation

KazuCocoa
Copy link
Member

Let's update existing e2e for send_keys with w3c action in selenium client way.
For now, this test should fail without appium/WebDriverAgent#919.

@KazuCocoa
Copy link
Member Author

oh...

9% of tests failed. This is (probably) fine

So this test failed actually but passed. Let me make the threshold strict a bit more

kkb912002
kkb912002 reviewed Jul 18, 2024
View reviewed changes
test/functional/basic/element-e2e-specs.js
actions: [
{type: 'pause', duration: 0},
{type: 'pause', duration: 0},
{type: 'pause', duration: 0}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 6 times.

@KazuCocoa KazuCocoa marked this pull request as ready for review July 18, 2024 08:17
@KazuCocoa KazuCocoa changed the title test: add sendkeys actions with another action like selenium client behaves fix: no actions in w3c actions case Jul 18, 2024
mykola-mokhnach
mykola-mokhnach reviewed Jul 18, 2024
View reviewed changes
.github/workflows/functional-test.yml Outdated
@@ -118,7 +118,7 @@ jobs:
failures=$(cat "$RESULTS_XML" | xq --xpath '//testsuite/@failures')
threshold=$(( (failures + errors) * 100 / (tests - skipped) ))
cat "$RESULTS_XML"
if [[ $threshold -gt 10 ]]; then
if [[ $threshold -gt 7 ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure we are ready to do this yet

@KazuCocoa
Copy link
Member Author

KazuCocoa commented Jul 19, 2024 •
edited
Loading

hm...

> appium-xcuitest-driver@7.24.0 lint
> eslint .

sh: 1: eslint: not found
Error: Process completed with exit code 12

https://github.com/appium/appium-xcuitest-driver/actions/runs/10002129669/job/27646928703?pr=2432

It looks like this is CI side issue.
I ran https://github.com/appium/appium-xcuitest-driver/actions/runs/9890897067 today, then the same result came while the same lint passed yesterday.

@mykola-mokhnach
Copy link
Contributor

hm...

> appium-xcuitest-driver@7.24.0 lint
> eslint .

sh: 1: eslint: not found
Error: Process completed with exit code 12

https://github.com/appium/appium-xcuitest-driver/actions/runs/10002129669/job/27646928703?pr=2432

It looks like this is CI side issue. I ran https://github.com/appium/appium-xcuitest-driver/actions/runs/9890897067 today, then the same result came while the same lint passed yesterday.

It's related to npm/cli#7667

KazuCocoa
KazuCocoa commented Jul 20, 2024
View reviewed changes
.github/workflows/unit-test.yml
@@ -27,6 +27,7 @@ jobs:
needs:
- prepare_matrix
strategy:
fail-fast: false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit test is pretty fast, so fail-fast: false should be good

@KazuCocoa KazuCocoa merged commit 8bd2bd6 into master Jul 20, 2024
17 of 18 checks passed
@KazuCocoa KazuCocoa deleted the add-tests-w3c-sendkeys branch July 20, 2024 08:55
github-actions bot pushed a commit that referenced this pull request Jul 20, 2024
@semantic-release-bot
chore(release): 7.24.1 [skip ci]
3db3352 
## [7.24.1](v7.24.0...v7.24.1) (2024-07-20)

### Bug Fixes

* no actions in w3c actions case ([#2432](#2432)) ([8bd2bd6](8bd2bd6))
@github-actions GitHub Actions
Copy link
Contributor

🎉 This issue has been resolved in version 7.24.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkb912002 kkb912002 kkb912002 left review comments

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KazuCocoa @mykola-mokhnach @kkb912002