Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #832 #834

Merged
merged 1 commit into from
Jul 1, 2013
Merged

Fix #832 #834

merged 1 commit into from
Jul 1, 2013

Conversation

bootstraponline
Copy link
Member

I think this should work.

To Do:

  • Fix selendroid

@bootstraponline
Copy link
Member Author

Fully qualified activity names don't work because the logic is this.appPackage + "/" + activityString I'm not sure a white list is a great solution.

@bootstraponline
Copy link
Member Author

I tested with my app: .the.activity the.activity my.pkg.the.activity all work.

@drpy
Copy link
Member

drpy commented Jun 30, 2013

Very well. Could you please also take a look into

ADB.prototype.pushSelendroid = function(cb) {
var cmd = this.adbCmd + " shell am instrument -e main_activity '" +
this.appPackage + "." + this.appActivity + "' " + this.appPackage +
".selendroid/io.selendroid.ServerInstrumentation";

Thank you.

Allow fully qualified activities

Fix selendroid
@bootstraponline
Copy link
Member Author

I fixed Selendroid.

jlipps added a commit that referenced this pull request Jul 1, 2013
@jlipps jlipps merged commit 0443dde into appium:master Jul 1, 2013
@bootstraponline bootstraponline deleted the 832 branch July 1, 2013 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants