-
Notifications
You must be signed in to change notification settings - Fork 187
chore: remove redundant pageobject feature #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
laolubenson
merged 1 commit into
appium:release/5.0.0
from
laolubenson:feat/remove-page-objects-v5
Oct 20, 2021
Merged
chore: remove redundant pageobject feature #472
laolubenson
merged 1 commit into
appium:release/5.0.0
from
laolubenson:feat/remove-page-objects-v5
Oct 20, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please provide a proper issue description? It is not very clear to me why this change is needed |
Collaborator
Author
|
@mykola-mokhnach done |
207792f to
6294052
Compare
Collaborator
Author
|
A force push merged this in. Build succeeded |
This was referenced Jul 23, 2025
This was referenced Aug 5, 2025
This was referenced Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Please provide briefly described change list which are you going to propose.
Types of changes
What types of changes are you proposing/introducing to .NET client?
Put an
xin the boxes that applyDocumentation
This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example
Integration tests
Details
Removes support for redundant SeleniumExtras code (containing the necessary Page object feature components). Removes the dependency to an unmaintained repository, unlinks this repository to selenium v3, and enables full .netStandard/core support.
The pageobject feature may return with .netStandard support in the future but will have to be a separate repo. Removing this code will prevent users from raising issues which lie in code that doesn't belong to us thus closes #444 #436 #385 #205 #179 #163 #121