Skip to content

chore: add deprecations for PerformTouchAction and PerformMultiAction v2 #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dor-bl merged 3 commits into from
Nov 11, 2022
Merged

chore: add deprecations for PerformTouchAction and PerformMultiAction v2 #553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
facf6bd
chore: add deprecations for PerformTouchAction and PerformMultiAction…
Dor-bl Nov 9, 2022
02ff9fb
chore: add deprecations for PerformMultiAction and PerformTouchAction…
Dor-bl Nov 9, 2022
47f4bc4
fix: Add missing [Obsolete] attribute
Dor-bl Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/Appium.Net/Appium/AppiumDriver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,23 +377,25 @@ public void DeactiveIMEEngine() =>

#endregion Input Method (IME)

#region Multi Actions

#region (Deprecated) Multi Actions
// TODO: Remove this region once we deprecate the touch actions
// Please use the W3C Actions instead.
[Obsolete("Touch Actions are deprecated in W3C spec, please use W3C actions instead")]
public void PerformMultiAction(IMultiAction multiAction)
{
if (multiAction == null) return;
var parameters = multiAction.GetParameters();
Execute(AppiumDriverCommand.PerformMultiAction, parameters);
}

[Obsolete("Touch Actions are deprecated in W3C spec, please use W3C actions instead")]
public void PerformTouchAction(ITouchAction touchAction)
{
if (touchAction == null) return;
var parameters = AppiumCommandExecutionHelper.PrepareArgument("actions", touchAction.GetParameters());
Execute(AppiumDriverCommand.PerformTouchAction, parameters);
}

#endregion Multi Actions
#endregion (Deprecated) Multi Actions

#region W3C Actions

Expand Down
6 changes: 4 additions & 2 deletions src/Appium.Net/Appium/AppiumDriverCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,9 @@ public class AppiumDriverCommand

#endregion Appium Specific extensions to JSONWP Commands

#region TouchActions
#region (Deprecated) TouchActions
// TODO: Remove this region once we deprecate the touch actions
// Please use the W3C Actions instead.

/// <summary>
/// Perform touch action
Expand All @@ -245,7 +247,7 @@ public class AppiumDriverCommand
/// </summary>
public const string PerformMultiAction = "performMultiTouch";

#endregion MultiTouchActions
#endregion (Deprecated) MultiTouchActions

#region W3C Actions

Expand Down