Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix assertion for logs entry #878

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

Dor-bl
Copy link
Collaborator

@Dor-bl Dor-bl commented Dec 13, 2024

List of changes

When getting bugreport logs, there is more than one entry.
can`t recall how it used to be.
@laolubenson / @KazuCocoa Maybe you guys recall if it's normal behavier:
image

Types of changes

What types of changes are you proposing/introducing to the .NET client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change that adds functionality or value)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • Test fix (non-breaking change that improves test stability or correctness)

Documentation

  • Have you proposed a file change/ PR with Appium to update documentation?

This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example

Integration tests

  • Have you provided integration tests for your changes? (required for Bugfix, New feature, or Test fix)

Details

Please provide more details about changes if necessary. You can provide code samples showing how they work and possible use cases if there are new features. Also, you can create gists with pasted C# code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub

@Dor-bl Dor-bl marked this pull request as ready for review December 13, 2024 21:15
@github-actions github-actions bot added the Test label Dec 13, 2024
Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's interesting. maybe something android behavior changed? the bug report itself is by adb I think.

@Dor-bl Dor-bl merged commit 9215929 into appium:main Dec 15, 2024
3 checks passed
@Dor-bl Dor-bl deleted the capture_bug_report_test branch December 20, 2024 22:23
@KazuCocoa KazuCocoa added the size:XS contribution size: XS label Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS contribution size: XS Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants