Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To make the swipe method deprecated and move it to TouchActions subclasses #456

Closed
TikhomirovSergey opened this issue Aug 9, 2016 · 0 comments
Closed

To make the swipe method deprecated and move it to TouchActions subclasses #456

TikhomirovSergey opened this issue Aug 9, 2016 · 0 comments
Assignees
@SrinivasanTarget
Labels
enhancement refactor
Milestone
5.0.0

Comments

@TikhomirovSergey
Copy link
Contributor

Description

To make the swipe method deprecated and move it to TouchActions subclasses:

  • mark the swipe method deprecated
  • to implement it (temporary solution)
  • to add the swipe method to TouchActions subclasses.
@TikhomirovSergey TikhomirovSergey added this to the 5.0.0 milestone Aug 9, 2016
@SrinivasanTarget SrinivasanTarget mentioned this issue Aug 12, 2016
Closed
3 tasks
@TikhomirovSergey TikhomirovSergey mentioned this issue Nov 12, 2016
Closed
3 tasks
TikhomirovSergey pushed a commit that referenced this issue Nov 24, 2016
@SrinivasanTarget @TikhomirovSergey
The addition to #513 (#514)
7042073 
* Splitting of TouchActions

* Codacy Fixes

* #456 FIX #454 FIX: API redesign.
- new interfaces were added
- deprecated API

* #456 FIX #454 FIX: MultiTouchAction refactoring
- new methods were added to MultiTouchAction
- AppiumDriver methods which perform multiple touch actions were marked as Deprecated
 - Constructors of TouchAction and MultiTouchAction were changed. Now it accepts any instance that can perform touch action and multiple touch actions.

* #456 FIX #454 FIX: New CreatesSwipeAction API

- the new interface CreatesSwipeAction was added.

- the reversion of last changes of TouchableElement.

- the `swipe` is deprecated method.

* #456 FIX #454 FIX:

Forgot to commit this change

* #456 FIX #454 FIX:  CreatesSwipeAction API was implemented

- CreatesSwipeAction API was implemented
- SwipeElementDirection was redesigned
- constructors of TouchAction and MultiTouchAction were improved.

* #456 FIX #454 FIX: AndroidTouchActions were covered with tests.

- also code issues were got fixed

* #456 FIX #454 FIX: Refactoring of MobileElement

* #456 FIX #454 FIX: IOSGesturesTest was redesigned.
- IOSSwipeGestureTest was added

* #456 FIX #454 FIX: Checkstyle issues were got fixed

* #456 FIX #454 FIX: The additional test on Android.
- the swiping combined with the tapping.

* Issues that found by codecy were got fixed

* The addition #513

Fixed Codacy errors

Fixed Codacy errors

* Fixed tests

Fixed tests

Fixed tests

Fixed tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SrinivasanTarget SrinivasanTarget

Labels
enhancement refactor
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
2 participants
@TikhomirovSergey @SrinivasanTarget