Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add threshold argument to OccurrenceMatchingOptions #1060

Merged
merged 2 commits into from
Nov 19, 2018
Merged

Add threshold argument to OccurrenceMatchingOptions #1060

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c949fb6
Add threshold argument to OccurrenceMatchingOptions
Nov 19, 2018
c5c1b2d
Fix linter
Nov 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions src/main/java/io/appium/java_client/imagecomparison/OccurrenceMatchingOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,31 @@

package io.appium.java_client.imagecomparison;

import static java.util.Optional.ofNullable;

import com.google.common.collect.ImmutableMap;

import java.util.Map;

public class OccurrenceMatchingOptions extends BaseComparisonOptions<OccurrenceMatchingOptions> {
private Double threshold;

/**
* At what normalized threshold to reject an occurrence.
*
* @param threshold value in range 0..1. 0.5 is the default value.
* @return self instance for chaining.
*/
public OccurrenceMatchingOptions withThreshold(double threshold) {
this.threshold = threshold;
return this;
}

@Override
public Map<String, Object> build() {
final ImmutableMap.Builder<String, Object> builder = ImmutableMap.builder();
builder.putAll(super.build());
ofNullable(threshold).map(x -> builder.put("threshold", x));
return builder.build();
}
}