Update javadoc of capabilities to follow latest Appium documents #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -69,6 +74,7 @@ | |||
| * Dismiss all iOS alerts automatically if they pop up. | |||
| * This includes privacy access permission alerts (e.g., | |||
| * location, contacts, photos). Default is false. | |||
| * Does not work on XCUITest-based tests. | |||
There was a problem hiding this comment.
it does starting from Appium 1.13.0
There was a problem hiding this comment.
Done. delete this line.
| @@ -175,8 +181,10 @@ | |||
| String TAP_WITH_SHORT_PRESS_DURATION = "tapWithShortPressDuration"; | |||
|
|
|||
| /** | |||
| * The capability to direct Appium to set the simulator scale. | |||
| * The XCUITest specific capability. | |||
| * Simulator scale factor. | |||
There was a problem hiding this comment.
This only works below Xcode9
There was a problem hiding this comment.
Added comment below this line.
|
Thanks @takeya0x86 . Please address linter issues from https://travis-ci.org/appium/java-client/builds/570742270?utm_source=github_status&utm_medium=notification |
9 tasks
|
@mykola-mokhnach Thank you for reviewing. I fixed these. And I also updated appium capability documents. |
mykola-mokhnach
approved these changes
Aug 13, 2019
| */ | ||
| String APP_WAIT_ACTIVITY = "appWaitActivity"; | ||
|
|
||
| /** | ||
| * Java package of the Android app you want to wait for. | ||
| * By default the value of this capability is the same as for {@code appActivity} |
There was a problem hiding this comment.
We can also mention, that this cap can include wildcards (*)
SrinivasanTarget
approved these changes
Aug 13, 2019
saikrishna321
approved these changes
Aug 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Update javadoc of capabilities to follow latest Appium documents.
https://github.com/appium/appium/blob/master/docs/en/writing-running-appium/caps.md
and
https://github.com/appium/appium-xcuitest-driver/blob/master/README.md#desired-capabilities
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that applyDetails
Please provide more details about changes if it is necessary. If there are new features you can provide code samples which show the way they
work and possible use cases. Also you can create gists with pasted java code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub