-
-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add support for viewmatcher #1293
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
32 changes: 32 additions & 0 deletions
32
src/main/java/io/appium/java_client/FindsByAndroidViewMatcher.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
/* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* See the NOTICE file distributed with this work for additional | ||
* information regarding copyright ownership. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package io.appium.java_client; | ||
|
||
import org.openqa.selenium.WebElement; | ||
|
||
import java.util.List; | ||
|
||
public interface FindsByAndroidViewMatcher<T extends WebElement> extends FindsByFluentSelector<T> { | ||
|
||
default T findElementByAndroidViewMatcher(String using) { | ||
return findElement(MobileSelector.ANDROID_VIEW_MATCHER.toString(), using); | ||
} | ||
|
||
default List<T> findElementsByAndroidViewMatcher(String using) { | ||
return findElements(MobileSelector.ANDROID_VIEW_MATCHER.toString(), using); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 46 additions & 0 deletions
46
src/test/java/io/appium/java_client/android/AndroidDataMatcherTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
/* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* See the NOTICE file distributed with this work for additional | ||
* information regarding copyright ownership. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package io.appium.java_client.android; | ||
|
||
import com.google.common.collect.ImmutableList; | ||
import com.google.common.collect.ImmutableMap; | ||
import io.appium.java_client.MobileBy; | ||
import org.junit.Test; | ||
import org.openqa.selenium.json.Json; | ||
import org.openqa.selenium.support.ui.ExpectedConditions; | ||
import org.openqa.selenium.support.ui.WebDriverWait; | ||
|
||
import static org.junit.Assert.assertNotNull; | ||
|
||
public class AndroidDataMatcherTest extends BaseEspressoTest { | ||
|
||
@Test | ||
public void testFindByDataMatcher() { | ||
final WebDriverWait wait = new WebDriverWait(driver, 10); | ||
wait.until(ExpectedConditions | ||
.elementToBeClickable(MobileBy.AccessibilityId("Graphics"))); | ||
driver.findElement(MobileBy.AccessibilityId("Graphics")).click(); | ||
|
||
String selector = new Json().toJson(ImmutableMap.of( | ||
"name", "hasEntry", | ||
"args", ImmutableList.of("title", "Sweep") | ||
)); | ||
|
||
assertNotNull(wait.until(ExpectedConditions | ||
.presenceOfElementLocated(MobileBy.androidDataMatcher(selector)))); | ||
} | ||
} |
42 changes: 42 additions & 0 deletions
42
src/test/java/io/appium/java_client/android/AndroidViewMatcherTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
/* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* See the NOTICE file distributed with this work for additional | ||
* information regarding copyright ownership. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package io.appium.java_client.android; | ||
|
||
import com.google.common.collect.ImmutableList; | ||
import com.google.common.collect.ImmutableMap; | ||
import io.appium.java_client.MobileBy; | ||
import org.junit.Test; | ||
import org.openqa.selenium.json.Json; | ||
import org.openqa.selenium.support.ui.ExpectedConditions; | ||
import org.openqa.selenium.support.ui.WebDriverWait; | ||
|
||
import static org.junit.Assert.assertNotNull; | ||
|
||
public class AndroidViewMatcherTest extends BaseEspressoTest { | ||
|
||
@Test | ||
public void testFindByViewMatcher() { | ||
String selector = new Json().toJson(ImmutableMap.of( | ||
"name", "withText", | ||
"args", ImmutableList.of("Animation"), | ||
"class", "androidx.test.espresso.matcher.ViewMatchers" | ||
)); | ||
final WebDriverWait wait = new WebDriverWait(driver, 10); | ||
assertNotNull(wait.until(ExpectedConditions | ||
.presenceOfElementLocated(MobileBy.androidViewMatcher(selector)))); | ||
} | ||
} |
67 changes: 67 additions & 0 deletions
67
src/test/java/io/appium/java_client/android/BaseEspressoTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
/* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* See the NOTICE file distributed with this work for additional | ||
* information regarding copyright ownership. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package io.appium.java_client.android; | ||
|
||
import io.appium.java_client.remote.AutomationName; | ||
import io.appium.java_client.remote.MobileCapabilityType; | ||
import io.appium.java_client.service.local.AppiumDriverLocalService; | ||
import io.appium.java_client.service.local.AppiumServerHasNotBeenStartedLocallyException; | ||
import org.junit.AfterClass; | ||
import org.junit.BeforeClass; | ||
import org.openqa.selenium.remote.DesiredCapabilities; | ||
|
||
import java.io.File; | ||
|
||
public class BaseEspressoTest { | ||
|
||
private static AppiumDriverLocalService service; | ||
protected static AndroidDriver<AndroidElement> driver; | ||
|
||
/** | ||
* initialization. | ||
*/ | ||
@BeforeClass public static void beforeClass() { | ||
service = AppiumDriverLocalService.buildDefaultService(); | ||
service.start(); | ||
|
||
if (service == null || !service.isRunning()) { | ||
throw new AppiumServerHasNotBeenStartedLocallyException( | ||
"An appium server node is not started!"); | ||
} | ||
|
||
File appDir = new File("src/test/java/io/appium/java_client"); | ||
File app = new File(appDir, "ApiDemos-debug.apk"); | ||
DesiredCapabilities capabilities = new DesiredCapabilities(); | ||
capabilities.setCapability(MobileCapabilityType.AUTOMATION_NAME, AutomationName.ESPRESSO); | ||
capabilities.setCapability(MobileCapabilityType.DEVICE_NAME, "Android Emulator"); | ||
capabilities.setCapability(MobileCapabilityType.APP, app.getAbsolutePath()); | ||
capabilities.setCapability("eventTimings", true); | ||
driver = new AndroidDriver<>(service.getUrl(), capabilities); | ||
} | ||
|
||
/** | ||
* finishing. | ||
*/ | ||
@AfterClass public static void afterClass() { | ||
if (driver != null) { | ||
driver.quit(); | ||
} | ||
if (service != null) { | ||
service.stop(); | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class chain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sin of copy & paste...I got it from the dataMatcher. I'll add a new commit in real quick, for the dataMatcher too. My apologies...