chore: Add non-W3C Location-management endpoints deprecated in Selenium client #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valfirst
requested review from
mykola-mokhnach,
SrinivasanTarget and
saikrishna321
as code owners
SrinivasanTarget
approved these changes
Jan 14, 2024
src/main/java/io/appium/java_client/remote/SupportsLocation.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/remote/SupportsLocation.java
Outdated
Show resolved
Hide resolved
valfirst
force-pushed
the
add-non-w3c-location-management-endpoints-deprecated-in-selenium-client
branch
from
06feb1f
to
5f36e28
Compare
src/main/java/io/appium/java_client/remote/SupportsLocation.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/remote/SupportsLocation.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/remote/SupportsLocation.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/remote/SupportsLocation.java
Outdated
Show resolved
Hide resolved
| locationParameters.put("latitude", location.getLatitude()); | ||
| locationParameters.put("longitude", location.getLongitude()); | ||
| Optional.ofNullable(location.getAltitude()).ifPresent(altitude -> locationParameters.put("altitude", altitude)); | ||
| execute(MobileCommand.SET_LOCATION, Map.of("location", location)); |
There was a problem hiding this comment.
locationParameters ?
mykola-mokhnach
approved these changes
Jan 15, 2024
valfirst
deleted the
add-non-w3c-location-management-endpoints-deprecated-in-selenium-client
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Add non-W3C Location-management endpoints deprecated in Selenium client: https://github.com/SeleniumHQ/selenium/pull/13372/files#diff-1af793ae2090a0cb691f1efbb3ee0d2b186c4027c5b441f6f3d55b3663e67ba1
Types of changes
What types of changes are you proposing/introducing to Java client?