-
-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#362 fix #413
Merged
Merged
#362 fix #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… java location r11226
… feel free to update if you disagree. r13571
…he selenium committers. Starting to update the copyright headers r16908
…ime. We are now the selenium project. No logical changes. r16915
Uses a line-comment format rather than block comments for consistency across languages.
… java location r11226
… feel free to update if you disagree. r13565
…he selenium committers. Starting to update the copyright headers r16908
…ime. We are now the selenium project. No logical changes. r16915
Uses a line-comment format rather than block comments for consistency across languages.
… java location r11226
… feel free to update if you disagree. r13565
…he selenium committers. Starting to update the copyright headers r16908
…ime. We are now the selenium project. No logical changes. r16915
Uses a line-comment format rather than block comments for consistency across languages.
… java location r11226
… feel free to update if you disagree. r13565
…he selenium committers. Starting to update the copyright headers r16908
…ime. We are now the selenium project. No logical changes. r16915
Uses a line-comment format rather than block comments for consistency across languages.
… java location r11226
… feel free to update if you disagree. r13565
…he selenium committers. Starting to update the copyright headers r16908
…ime. We are now the selenium project. No logical changes. r16915
Uses a line-comment format rather than block comments for consistency across languages.
… java location r11226
… feel free to update if you disagree. r13565
…he selenium committers. Starting to update the copyright headers r16908
Fixes issue #4290.
…code.google.com/p/selenium/source/browse/spec-draft.md?repo=mobile#133 - this feature will be used by mobile WebDriver users to switch between different contexts like the native or the webview UI element tree - The feature is end to end tested with latest selendroid snapshot version (6a126ab3782deb7dd0cc99c6e3785c72d636959b)
Subclasses of RemoteWEbDriver that need this should extend TargetLocator and use covariant return types to keep everything happy and sweet.
built using java 8
Uses a line-comment format rather than block comments for consistency across languages.
Changes from the SeleniumHQ/selenium#863
@SrinivasanTarget @bootstraponline |
I'm addind snapshot for people who want to test/play around these changes. |
@TikhomirovSergey LGTM👍 @simongranger Can you guys have a look on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
It is fix of #362. Related issues: #220, #323
Change list:
Types of changes
Details
These changes were supposed to be merged at SeleniumHQ/selenium#863. We are facing the critical issue (may be blocker) now. As soon as the PR is not merged yet and it won't be merged the near future.
Advantages:
It works even if pom is configured like
Disadvantages:
It requires the switching to Eclipse compiler. However it works perfectly in Eclips IDE because it uses that compiler by default.
It is possible to fix this this issue by the adding of modified RemoteWebDriver/RemoteWebElement. But presence of these classes at the java_client bundle is risky.
All that is needed till Java: All searching interfaces are made generic SeleniumHQ/selenium#863 or similar change is merged.
However Selenium API is not frequently changed.