Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#362 fix #413

Merged
merged 114 commits into from
Jun 15, 2016
Merged

#362 fix #413

merged 114 commits into from
Jun 15, 2016

Conversation

TikhomirovSergey
Copy link
Contributor

@TikhomirovSergey TikhomirovSergey commented Jun 10, 2016

Change list

It is fix of #362. Related issues: #220, #323

Change list:

  • the whole content of the the io.appium.java_client.generic.searchcontext was marked @deprecated. It is redundant now.
  • some part of Selenium API was added to the project. All the Selenium upstream history was saved.
  • the added Selenium API part was modified in required way.
  • API improvement.
  • code style validation became not so strict.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

These changes were supposed to be merged at SeleniumHQ/selenium#863. We are facing the critical issue (may be blocker) now. As soon as the PR is not merged yet and it won't be merged the near future.

Advantages:

  • It is possible to use javac compiler when user tries to extend something that included to java_client dependency.

image

image

  • common Selenium API flexibility (!!!).

image

image

It works even if pom is configured like

         <dependency>
            <groupId>io.appium</groupId>
            <artifactId>java-client</artifactId>
            <version>5.0.0-SNAPSHOT</version>
            <exclusions>
                <exclusion>
                    <groupId>org.seleniumhq.selenium</groupId>
                    <artifactId>selenium-java</artifactId>
                </exclusion>
            </exclusions>
        </dependency>
        <dependency>
            <groupId>org.seleniumhq.selenium</groupId>
            <artifactId>selenium-java</artifactId>
            <version>2.52.0</version>
        </dependency>

image

image

Disadvantages:

  • It is impossible to override List searching methods with javac compiler.

image

It requires the switching to Eclipse compiler. However it works perfectly in Eclips IDE because it uses that compiler by default.

image

It is possible to fix this this issue by the adding of modified RemoteWebDriver/RemoteWebElement. But presence of these classes at the java_client bundle is risky.

shs96c and others added 30 commits June 5, 2016 21:38
…he selenium committers. Starting to update the copyright headers

r16908
…ime. We are now the selenium project. No logical changes.

r16915
Uses a line-comment format rather than block comments for consistency
across languages.
…he selenium committers. Starting to update the copyright headers

r16908
…ime. We are now the selenium project. No logical changes.

r16915
Uses a line-comment format rather than block comments for consistency
across languages.
…he selenium committers. Starting to update the copyright headers

r16908
…ime. We are now the selenium project. No logical changes.

r16915
Uses a line-comment format rather than block comments for consistency
across languages.
…he selenium committers. Starting to update the copyright headers

r16908
…ime. We are now the selenium project. No logical changes.

r16915
Uses a line-comment format rather than block comments for consistency
across languages.
…he selenium committers. Starting to update the copyright headers

r16908
…ime. We are now the selenium project. No logical changes.

r16915
Uses a line-comment format rather than block comments for consistency
across languages.
…he selenium committers. Starting to update the copyright headers

r16908
barancev and others added 17 commits June 6, 2016 00:18
…code.google.com/p/selenium/source/browse/spec-draft.md?repo=mobile#133 - this feature will be used by mobile WebDriver users to switch between different contexts like the native or the webview UI element tree - The feature is end to end tested with latest selendroid snapshot version (6a126ab3782deb7dd0cc99c6e3785c72d636959b)
Subclasses of RemoteWEbDriver that need this should extend TargetLocator
and use covariant return types to keep everything happy and sweet.
Uses a line-comment format rather than block comments for consistency
across languages.
…w / cookie commands.

changing how W3C dialect is detected by checking if 'status' is sent in the new session response
switch to window in w3c passes in 'handle' variable instead of 'name'

Fixes #1242
Fixes #1241
Fixes #1240
Fixes #1238
Fixes #1237
@TikhomirovSergey
Copy link
Contributor Author

@SrinivasanTarget @bootstraponline
Could you review this PR?

@TikhomirovSergey
Copy link
Contributor Author

I'm addind snapshot for people who want to test/play around these changes.
5.0.0-SNAPSHOT.zip

@SrinivasanTarget SrinivasanTarget added this to the 4.1.0 milestone Jun 10, 2016
@SrinivasanTarget
Copy link
Member

SrinivasanTarget commented Jun 11, 2016

@TikhomirovSergey LGTM👍

@simongranger Can you guys have a look on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.