Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convenient access to commands #445

Merged
merged 5 commits into from
Jul 29, 2016
Merged

Convenient access to commands #445

merged 5 commits into from
Jul 29, 2016

Conversation

TikhomirovSergey
Copy link
Contributor

@TikhomirovSergey TikhomirovSergey commented Jul 27, 2016

Change list

  • update to Selenium 2.53.1
  • the new class CommandExecutionHelper
  • the new class AndroidMobileCommandHelper
  • the new class IOSMobileCommandHelper
  • MobileCommand.commandRepository is mutable now. Additional commands could be defined via
    MobileCommand.commandRepository.put(String, CommandInfo) there.
  • source code reafactoring

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

There are projects which based on Appium (modifications, additional customized automation layers and so on). In order to make client convenient these chandes were made:

  • the ability to define additional commands directly was provided.
    MobileCommand.commandRepository.put(String, CommandInfo)
  • access to mobile OS-specific commands and execution was made easier
  • was added the ability to implement specific exctentions of the accessing to additional commands and execition.

@TikhomirovSergey
Copy link
Contributor Author

TikhomirovSergey commented Jul 27, 2016

@SrinivasanTarget @jlipps @philgreenyouilabs @pfoster-youitv @simongranger
Could you please review this PR?

#429

@SrinivasanTarget
Copy link
Member

@TikhomirovSergey Interesting. I like this PR 👍there are some remarks from @codacy-bot. I will review soon.

@pfoster-youitv
Copy link
Contributor

Looks to be about the same as what you showed me on your fork. I took that previous one and made use of it for our You.i Engine side of things and it worked really well.

I liked how I could subclass AppiumDriver and import commands from various devices. This will really make cross platform commands easier to call.

👍 from me

@TikhomirovSergey TikhomirovSergey changed the title Convenient access to commands commands Convenient access to commands Jul 28, 2016
@TikhomirovSergey
Copy link
Contributor Author

@SrinivasanTarget Issues were fixed. You are free to review it

@SrinivasanTarget
Copy link
Member

@TikhomirovSergey LGTM 👍

@TikhomirovSergey TikhomirovSergey merged commit 09eede8 into appium:master Jul 29, 2016
@TikhomirovSergey TikhomirovSergey mentioned this pull request Jul 31, 2016
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants