Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#455 fix #462

Merged
merged 4 commits into from
Aug 28, 2016
Merged

#455 fix #462

merged 4 commits into from
Aug 28, 2016

Conversation

TikhomirovSergey
Copy link
Contributor

Change list

  • the new enum MobileSelector was added.
  • the refactoring of the MobileBy.
  • the new interface FindsByFluentSelector was added.
  • the refactoring of the IOSDriver and IOSElement.
  • the refactoring of the AndroidDriver and AndroidElement.
  • API was changed.
  • with @Rafael-Chavez 's authorship
    • the new interface FindsByIosNSPredicate was added
    • the new searching strategy ByIosNsPredicate was added
  • with @JonStoneman 's authorship
    • the new interface FindsByWindowsAutomation was added
    • the new searching strategy ByWindowsAutomation was added

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

TikhomirovSergey and others added 3 commits August 23, 2016 13:41
-  the new interface FindsByFluentSelector was added.

-  the new enum MobileSelector was added.

- the refactoring of the MobileBy.

- the refactoring of the IOSDriver and IOSElement.

- the refactoring of the AndroidDriver and AndroidElement.

- API was changed.
@TikhomirovSergey
Copy link
Contributor Author

@SrinivasanTarget @Rafael-Chavez @JonStoneman
Could you review this PR?

@stoneman
Copy link
Contributor

The windows bits look good to me. As with the .net client, we'll have to wait and see if the server will actually support -windows uiautomation.

@SrinivasanTarget
Copy link
Member

@TikhomirovSergey LGTM 👍 Awesome new additions:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants